Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce cookbook documentation #1826

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

WebMamba
Copy link
Contributor

@WebMamba WebMamba commented May 4, 2024

Q A
Bug fix? no
New feature? yes
Issues
License MIT

This PR introduces a new section for the UX website: cookbook. This section aims to give more concrete documentation, show examples of common things implemented with UX components, and go deeper into some concepts that we do in the documentation. The goal is not to replace the documentation but to illustrate
the documentation with concrete examples.

Capture d’écran 2024-05-04 à 17 14 24 Capture d’écran 2024-05-04 à 17 15 38

How it's implemented?

Simply by creating a .md file in the recipes directory at the route of the project, then everything is generated automatically. There are cookbook pages that show all the recipes available, then you can click on the recipe to read it.

Who can add recipes to the cookbook?

Anyone! If you thing you implemented something a bit complex but common, just show you did it!

Thank you!
Tell me what you think 😁

@carsonbot carsonbot added Feature New Feature Status: Needs Review Needs to be reviewed labels May 4, 2024
@WebMamba WebMamba force-pushed the introduce_cookbook_documentation branch 5 times, most recently from 9cc6c95 to cfeb25a Compare May 4, 2024 16:19
@smnandre
Copy link
Member

smnandre commented May 5, 2024

I'll review tomorrow or tuesday in depth.. but the overall mood: i love it !

@ludovik-dev
Copy link

It's a bit related to the PR #1347?

@smnandre
Copy link
Member

smnandre commented May 7, 2024

It's a bit related to the PR #1347?

A bit .. but the "recipe" term refer to a "cookbook recipe" more than a "component recipe" :)

Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this @WebMamba!

I'm thinking, accross the board, we should use the term "cookbook" to not be confused with the future "recipes" idea.

For the markdown, take a look at the front matter extension. I think this could be leveraged here.

@smnandre
Copy link
Member

smnandre commented May 8, 2024

How do you want to proceed @WebMamba here ? Do we review both content / feature here ? Or you prefer just the "code" part for now maybe ?

@WebMamba WebMamba force-pushed the introduce_cookbook_documentation branch 2 times, most recently from 74fd42d to 4552ab1 Compare May 12, 2024 16:11
@WebMamba
Copy link
Contributor Author

@smnandre lets focus on the code at first, and then on the content. Even if we do that in two times, I can keep the content of the recipe on this PR, I think it's better if we launch the cookbook with a first article.

@kbond thanks, I use the front matter extension now, this is pretty cool!

@codisart thanks for your review I applied your fix!

@smnandre
Copy link
Member

As soon as i find 15mn i'll review it i swear 😮‍💨

@@ -0,0 +1,66 @@
.Recipe {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for you if i create some generic "content page CSS base" ? I fear we have a lot of similar "component" like this one ?

Copy link
Member

@smnandre smnandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So at lot of comments, but this is not to discourage you :)

I'll open some PR this week-end that would probably remove a lot of them (some generic system based on your work to load content, list them, cache them....)

And i'll try to adapt "CodeBlock" to remove the requirement of having a file.

And i really like lots of small improvements / ideas this PR brings 😄


***How does it work into Symfony?***

Let's take the example of the Alert component an [anonymous component](https://symfony.com/bundles/ux-twig-component/current/index.html#anonymous-components).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we find a system for generic local links ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get what you mean. Do you implements something to generate better link to the docs ?

@WebMamba WebMamba force-pushed the introduce_cookbook_documentation branch from 4552ab1 to 9be6a1f Compare July 17, 2024 11:56
@WebMamba
Copy link
Contributor Author

I am back on this @smnandre I addressed most of your comment, I think I may need some help with the css to make think a bit more prettier

@smnandre
Copy link
Member

I am back on this @smnandre I addressed most of your comment, I think I may need some help with the css to make think a bit more prettier

With pleasure (and it's time we move forward this project -- sorry last weeks have been really busy). This week-end i'll have time to work on this 😽

@WebMamba WebMamba force-pushed the introduce_cookbook_documentation branch 2 times, most recently from e995211 to 2f86503 Compare July 19, 2024 09:26
@kbond kbond force-pushed the introduce_cookbook_documentation branch from 2f86503 to 6bfa523 Compare July 31, 2024 22:26
@kbond
Copy link
Member

kbond commented Jul 31, 2024

Thanks Matheo.

@kbond kbond merged commit b066280 into symfony:2.x Jul 31, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants